Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTC sometimes reports the value as 16,777,214.00 °C #13

Open
Arise opened this issue Feb 5, 2023 · 1 comment
Open

OTC sometimes reports the value as 16,777,214.00 °C #13

Arise opened this issue Feb 5, 2023 · 1 comment

Comments

@Arise
Copy link

Arise commented Feb 5, 2023

For some reason my Boiler reports the external probe temperature as: 16,777,214.00 °C. I think this happens when the external temperature is around value 0.

image

@Arise
Copy link
Author

Arise commented Feb 9, 2023

    float parse_f88(const unsigned long response) {
        unsigned int data = response & 0xffff;
        return (data & 0x8000) ? -(0x10000L - data) / 256.0f : data / 256.0f; 
    }

I think is not ok to store data variable in an unsigned int. Maybe we should use a unsigned short or uint16_t for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant