Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send messages for features not supported by the boiler #4

Open
arthurrump opened this issue Oct 1, 2022 · 0 comments
Open

Don't send messages for features not supported by the boiler #4

arthurrump opened this issue Oct 1, 2022 · 0 comments

Comments

@arthurrump
Copy link
Owner

For some features the boiler can indicate support through special messages, currently exposed as binary sensors:

  • dhw_present for Status(dhw_enable) and dhw related messages
  • cooling_supported for Status(cooling_enable) and cooling_control
  • ch2_present for Status(ch2_active) and ch2 related messages
  • dhw_setpoint_transfer_enabled for reading t_dhw_set
    • & dhw_setpoint_rw for writing t_dhw_set
  • max_ch_setpoint_transfer_enabled for reading max_t_set
    • & max_ch_setpoint_rw for writing max_t_set

If one of the messages is being sent that has a support indicator, we should query support at startup and automatically disable all unsupported messages. This information should probably be included in the schema, either in the binary sensors as an indicates_support_for or in the entity's with some support_indicated_by with a format similar to auto_min/max_value.

Clear logging is required, so useful to do this on startup as users are more likely to see the logs at that point.
cadavre referenced this issue in cadavre/esphome-opentherm Apr 26, 2024
@spattinson
Changed the PID to temperature calculation. Previously on a boiler th…
8fe5c1d 
…at (ov1d1u#4)

has a min flow temp of 50C and a max of 70C set the pid output would be
clipped, a pid output of 100% would be 70C as you expect, but a pid
output of 70% is the same as 100% - 70C. The same goes for minimum flow
temp, 1% to 50% pid output produces a flow temp of 50C.

This is problematic for PID tuning, producing results which dont work.
It also causes bigger jumps in temperature when PID is modulating in the
50-70% range, a large drop in requested temperature will result in the
boiler shutting off instead of modulating down. Since I implemented the
change on my system I'm seeing more stable temperature regulation,
much less target temperature overshoot, and much less boiler cycling on
and off, which is how an opentherm system should work. Setting output
sample averaging also helps to smooth the boiler setpoint, I am
currently using 2.

My system is an Intergas 18kw system boiler with 14 radiators in a poorly
insulated Victorian home built in 1898 for reference. The outside
temperature while testing has been in the range -4 to 2C, inside room
setpoint 20.8C
FreeBear-nc pushed a commit to FreeBear-nc/esphome-opentherm that referenced this issue Nov 16, 2024
@olegtarasov
Merge pull request arthurrump#4 from FreeBear-nc/main
0dec685 
Add a few more sensors to schema.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arthurrump