Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve typing and docs in genet methods #191

Open
KasiaKoz opened this issue Sep 28, 2023 · 0 comments
Open

Improve typing and docs in genet methods #191

KasiaKoz opened this issue Sep 28, 2023 · 0 comments

Comments

@KasiaKoz
Copy link
Collaborator

GeNet requires better typing and documentation of arguments and methods - this is expected to be a big overhaul.

e.g. use of Optional[str] = None instead of str = None in optional/defaulted arguments and typing mandatory ones
https://github.com/arup-group/genet/blob/main/genet/utils/google_directions.py#L19-L21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KasiaKoz