Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support verbose logging as CLI flag #2

Open
arvryna opened this issue Jul 31, 2021 · 2 comments
Open

Support verbose logging as CLI flag #2

arvryna opened this issue Jul 31, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@arvryna
Copy link
Owner

arvryna commented Jul 31, 2021

No description provided.

@arvryna arvryna added enhancement New feature or request good first issue Good for newcomers labels Jul 31, 2021
@hsblhsn
Copy link

hsblhsn commented Feb 21, 2022

Hi, can you tell me a little bit about it? If I am right, you might want to print more verbose logs with -v or -verbose flag.

What do you think about leveled logging? So, the user can always prefer what kind of logs they want. And the input can be given by --log-level flag or LOG_LEVEL env variable.

What do you think?

@arvryna
Copy link
Owner Author

arvryna commented Feb 21, 2022

Hey @hsblhsn, thanks for your interest !

yes, you are right, i would like to introduce a new flag, which gives an opportunity to print more details to console. At this point the CLI is very simple utility, doesn't require a levelled logging.

These are the implementation steps i have in mind:

  1. Introducing a new flag in the app (please note: already such a flag exist (-v) for printing version), we should come up with a different name of the flag.

  2. Identifying areas in code , where printing extra information makes sense

  3. Using only standard libraries without using any external dependencies.

  4. Adding a new internal package for logging, that contains a function, something like printLog, that can do the logging based on the flag state (if verbose is required or not).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants