Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sliding window log issue #20

Open
dithya512m opened this issue Aug 25, 2024 · 0 comments
Open

Sliding window log issue #20

dithya512m opened this issue Aug 25, 2024 · 0 comments

Comments

@dithya512m
Copy link

As per the your article, the request is added to the queue even if the request isn't allowed. But in the implementation you check if the queue size is less than capacity before adding.

Your LeakyBucket and Sliding Window Log implementations are almost the same, or am I missing something? The class accepts two parameters and queue polling is the same.

Also, in leakyBucket, queue polling should be done by the server attached to rate limit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant