ruff server hangs when performing "code actions" in Helix

[schlich]

Might be related to Issue #416 in ruff-lsp, particularly @ssmsossah's comment here that the same thing is happening in NeoVim.

Running ruff server in Helix. Health checks with hx --health python all pass.

Helix 24.7
ruff 0.6.0
protocol error: InternalError: failed to deserialize diagnostic data: missing field 'range'

[[language]]
name = "python"
formatter = { command = "ruff", args = ["format", "-"]}
language-servers = ["ruff", "pyright", "pylsp"]

[language-server.pyright.config.python.analysis]
typeCheckingMode = "basic"

[language-server.ruff]
command = "ruff"
args = ["server"]

[schlich]

Welp, looks like I just rubber-ducked my way out of this one. dunno how that misconfig slipped in but changing args = ["server"] to config = { settings = { args = ["server"] } } as suggested in the helix docs fixed the issue... closing.

[dhruvmanila]

I'm a bit confused here. What was the exact change? The args = ["server"] should be correct unless Helix changed something. Can you provide the docs reference for this?

[schlich]

@dhruvmanila it's here

[language-server.ruff]
command = "ruff"
config = { settings = { args = ["server"] } }

[dhruvmanila]

That's weird because their documentation mentions the use of args:

args | A list of arguments to pass to the language server binary

while, the config key is actually the initialization options which is different.

I'll need to try this out.

[dhruvmanila]

I'm getting code actions:

Using the following config:

[[language]]
name = "python"
language-servers = ["ruff", "pyright"]

[language-server.pyright]
command = "pyright-langserver"
args = ["--stdio"]

[language-server.ruff]
command = "ruff"
args = ["server"]

[schlich]

that is weird. if you think it's worth further reproducing the issue on my end, just let me know @dhruvmanila. Maybe there are logs I can pull? The related issues make me skeptical it's a Helix-specific problem

[dhruvmanila]

Is the config that you provided in the PR description complete? If not, could you provide the remaining parts? I'm curious whether you're using python-lsp-ruff (plugin to pylsp).

It might also be worth discussing this with the Helix team. Is it args or config? Because, we're using args in our setup guide :)

[schlich]

Yes, that was the complete config for the python language. I tried it with various combinations of pylsp, pyright, and pylyzer. definitely was not including python-lsp-ruff even though i have used it in the past, I was assuming hopefully correctly that ruff server was a full replacement.

I just confirmed the error is persisting when i revert the change, right now i'm just running ruff and pylyzer

we're using args in our setup guide

ah, so that's how i ended up there!