You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
thank you for your continued efforts in conceiving Ruff.
While working on crate/cratedb-toolkit#81, we just observed a funny case of S608 Possible SQL injection vector through string-based query construction we would like to share with you. It is easy to reproduce using the most recent ruff 0.1.5.
variants= ["foo", "bar"]
raiseValueError(f"Please select a value from the list of possible variants: {variants}.")
It looks like S608 is tripping because the f-string includes the keywords select and from. If you remove any of it, it will not trip. I don't know if there will be any solution for this worth to follow up on. It is easy for me to slap a # noqa: S608 into the code, so you may want to close this issue right away.
With kind regards,
Andreas.
The text was updated successfully, but these errors were encountered:
Hi there,
thank you for your continued efforts in conceiving Ruff.
While working on crate/cratedb-toolkit#81, we just observed a funny case of
S608 Possible SQL injection vector through string-based query construction
we would like to share with you. It is easy to reproduce using the most recentruff 0.1.5
.It looks like S608 is tripping because the f-string includes the keywords
select
andfrom
. If you remove any of it, it will not trip. I don't know if there will be any solution for this worth to follow up on. It is easy for me to slap a# noqa: S608
into the code, so you may want to close this issue right away.With kind regards,
Andreas.
The text was updated successfully, but these errors were encountered: