Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexpected items in sdist #10771

Closed
cjw296 opened this issue Jan 20, 2025 · 3 comments
Closed

unexpected items in sdist #10771

cjw296 opened this issue Jan 20, 2025 · 3 comments
Labels
upstream An upstream dependency is involved

Comments

@cjw296
Copy link

cjw296 commented Jan 20, 2025

I created this distribution from this commit. and have found it contains some expected content:

$ tar -tzf dist/paradigms-0.0.0.dev0.tar.gz 
paradigms-0.0.0.dev0/.python-version
paradigms-0.0.0.dev0/uv.lock
paradigms-0.0.0.dev0/.idea/.gitignore
paradigms-0.0.0.dev0/.idea/encodings.xml
paradigms-0.0.0.dev0/.idea/misc.xml
paradigms-0.0.0.dev0/.idea/modules.xml
paradigms-0.0.0.dev0/.idea/paradigms.iml
paradigms-0.0.0.dev0/.idea/vcs.xml
paradigms-0.0.0.dev0/.idea/workspace.xml
paradigms-0.0.0.dev0/.idea/inspectionProfiles/Project_Default.xml
paradigms-0.0.0.dev0/.idea/inspectionProfiles/profiles_settings.xml
paradigms-0.0.0.dev0/src/paradigms/__init__.py
paradigms-0.0.0.dev0/src/paradigms/py.typed
paradigms-0.0.0.dev0/.gitignore
paradigms-0.0.0.dev0/.hgignore
paradigms-0.0.0.dev0/README.md
paradigms-0.0.0.dev0/pyproject.toml
paradigms-0.0.0.dev0/PKG-INFO

Where would that .hgignore have come from? I don't have such a file in the project, if I did it would have from uv init --lib, but I don't think that lays down such a file?

The .idea directory shouldn't be there, I have it excluded from git in a user-wide .gitignore:

$ cat ~/.gitignore 
.#*
.DS_Store
*.pyc
*.tgz
*.tar.gz
.idea
/.Python
/bin
/include
/lib

Why is it being included?

@FishAlchemist
Copy link
Contributor

FishAlchemist commented Jan 20, 2025

https://github.com/simplistix/paradigms/blob/8f96ce34eaefd5258897f9047f9670435db3fad5/pyproject.toml#L12-L14

[build-system]
requires = ["hatchling"]
build-backend = "hatchling.build"

I don't think it's a UV issue; I think it's a hatchling problem.

By default, Hatch will respect the first .gitignore or .hgignore file found in your project's root directory or parent directories.

Ref: https://hatch.pypa.io/latest/config/build/#vcs
Ref: pypa/hatch#304

@konstin konstin added the upstream An upstream dependency is involved label Jan 20, 2025
@cjw296
Copy link
Author

cjw296 commented Jan 21, 2025

Thanks! Is that likely to be the source of the mysterious .hgignore too? I've never used mercurial on the above machine, so pretty mystified!

@charliermarsh
Copy link
Member

I think so? We don't have any references to .hgignore in our codebase, so it doesn't seem like uv would do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream An upstream dependency is involved
Projects
None yet
Development

No branches or pull requests

4 participants