Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor codebase to reuse method from _utils/importer.py #1519

Open
pankajkoti opened this issue Feb 7, 2025 · 0 comments
Open

Refactor codebase to reuse method from _utils/importer.py #1519

pankajkoti opened this issue Feb 7, 2025 · 0 comments
Assignees
@pankajkoti
Milestone
Cosmos 1.10.0

Comments

@pankajkoti
Copy link
Contributor

PR #1509 introduces a new module, _utils/importer.py, which includes the load_method_from_module function to retrieve a callable from a module within the Cosmos package.

Refactor existing code that implements similar functionality to use this new method, eliminating duplicate logic.

Instances of such duplication can be found at:

  1. cosmos/core/airflow.py#L27
  2. cosmos/operators/_asynchronous/base.py#L29
@pankajkoti pankajkoti self-assigned this Feb 7, 2025
@pankajkoti pankajkoti added this to the Cosmos 1.9.0 milestone Feb 7, 2025
@tatiana tatiana modified the milestones: Cosmos 1.9.0, Cosmos 1.10.0 Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pankajkoti pankajkoti

Labels
None yet
Projects
None yet
Milestone
Cosmos 1.10.0
Development

No branches or pull requests
2 participants
@tatiana @pankajkoti