From 2151d45c1e3520bca0120ba52428ae7afbc923ed Mon Sep 17 00:00:00 2001 From: Kenneth Aasan Date: Thu, 29 Feb 2024 17:39:51 +0100 Subject: [PATCH] fixes sonar --- playground/components/CodeEditorComponent.tsx | 4 ++-- playground/components/Tab.tsx | 6 ++++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/playground/components/CodeEditorComponent.tsx b/playground/components/CodeEditorComponent.tsx index 502420907..024bbcdac 100644 --- a/playground/components/CodeEditorComponent.tsx +++ b/playground/components/CodeEditorComponent.tsx @@ -21,8 +21,8 @@ class CodeEditorComponent extends Component { componentDidUpdate(nextProps: Props) { const { externalResource } = this.props; - if (nextProps.externalResource !== externalResource) { - this.setState({ code: externalResource! }); + if (externalResource && nextProps.externalResource !== externalResource) { + this.setState({ code: externalResource }); } } diff --git a/playground/components/Tab.tsx b/playground/components/Tab.tsx index be9208ec3..3dd1bff61 100644 --- a/playground/components/Tab.tsx +++ b/playground/components/Tab.tsx @@ -3,7 +3,7 @@ import React, { Component } from 'react'; import { TabLink, TabWrapper } from './styled'; export interface TabProps { - children: React.ReactNode; + children: React.ReactNode; // NOSONAR title: string; tabIndex?: number; isActive?: boolean; @@ -19,7 +19,9 @@ class Tab extends Component { { event.preventDefault(); - parentCallback!(tabIndex!); + if (parentCallback && tabIndex) { + parentCallback(tabIndex); + } }} active={isActive} >