fix: add studio-version param to studio URL to address cache issues
#1182
Conversation
Amzani
requested review from
Souvikns,
magicmatatjahu,
derberg and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
/au |
src/models/Studio.ts
Outdated
| wsServer.on('close', (socket: any) => { | ||
| sockets.splice(sockets.findIndex(s => s === socket)); | ||
| }); | ||
|
|
||
| server.listen(port, () => { | ||
| const url = `http://localhost:${port}?liveServer=${port}`; | ||
| const url = `http://localhost:${port}?liveServer=${port}&_sv=${studioVersion}`; |
There was a problem hiding this comment.
are you sure this is a solution? In linked issue nobody specified that 1.4.0 of CLI was used, and older version did not have latest studio
also where is this _sv param coming from?
There was a problem hiding this comment.
Yes, it's not the most exciting solution, but we should find a way to completely disable the browser cache in the local HTTP server we are using to start Studio.
The issue happens for new CLI versions, even though we have the latest studio version.
_sv -> studio version.
There was a problem hiding this comment.
There was a problem hiding this comment.
oh crap 🤔
ok, so _sv has no meaning for studio really, it is just a hack to force "refresh".
I think it is good, also useful as it informs what studio version you are using.
This is why, what about using full name for the query param? so it is immediately clear what that is?
There was a problem hiding this comment.
@derberg done, you take a look?
Amzani
force-pushed
the
samz/fix-studio-cache-issues
branch
from
81b11cd to
03a0ce8
Compare
|
derberg
changed the title
studio-version param to studio URL to address cache issues
|
/rtm |
|
🎉 This PR is included in version 1.5.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes #1098
Note: The browser might cache old studio version that doesn't support 3.0.0