Donating proto-parser

[GreenRover]

I created a parser for Protocoll Buffer:
https://github.com/GreenRover/proto-schema-parser
and want to donate it to AsyncApi.

The parser allows to handle proto buff message paylaoad. Example:

asyncapi: 2.0.0
info:
  title: Example using ProtoBuff data types
  version: '1.0.0'
channels:
  mychannel:
    publish:
      message:
        $ref: '#/components/messages/testMessage'

components:
  messages:
    testMessage:
      schemaFormat: 'application/vnd.google.protobuf;version=2'
      payload: |
        message Point {
          required int32 x = 1;
          required int32 y = 2;
          optional string label = 3;
        }

        message Line {
          required Point start = 1;
          required Point end = 2;
          optional string label = 3;
        }

As visible in example. The root type will be detected and used (if there is not exactly 1 root type an Exception will be thrown)

Visualization was with react module was tested:

Initial code owner:
@GreenRover

Pinging @asyncapi/tsc_members for voting, if you have any questions don't be shy!

[smoya]

YES.

We need to work on the README to clarify the supported versions of protobuf and the compatibility with the AsyncAPI Parser-JS, as Parser-JS v2 introduces an interface for Schema Parsers.
I also created an issue that IMHO should be solved but so far looks good to me!

Happy to help with that.

[smoya]

@smoya @fmvilas The readme is copied from: https://github.com/asyncapi/raml-dt-schema-parser You should improve this as well.
I now use https://github.com/asyncapi/avro-schema-parser readme as template.

I think just adding the things I mentioned will do the job.
Creating a standard Readme template for Schema Parsers would be nice though. Anyway out of the scope of this.

And of course, the rest of Readme files will be improved eventually as well.

[GreenRover]

I improved the documentation now.

What do you mean with:

the compatibility with the AsyncAPI Parser-JS, as Parser-JS v2 introduces an interface for Schema Parsers.

The parser:
https://www.npmjs.com/package/@asyncapi/parser

is at version 1.18.1 (the version i tested against)

[smoya]

@GreenRover You might want to take a look to this GreenRover/proto-schema-parser#2

[GreenRover]

@smoya i would prefer to make a first parser 1.x release to npm.
Than migrate to parser 2.x
To provide support for parser 1.x
I will prepare a branch but not merge to master

[smoya]

Makes totally sense @GreenRover 👍

[magicmatatjahu]

Yes :) 🚀

[fmvilas]

Yes! This will help us experiment with protobuf before we give it first-class support in the spec.

[GreenRover]

how can we get here any progress?

[derberg]

Hey @GreenRover 👋🏼

Can you specify who will maintain this project?
From https://github.com/GreenRover/proto-schema-parser/blob/master/CODEOWNERS I see just you, GreenTower is probably a spelling mistake.

We need minimum 2 people for the project.

Also will you act as individual contributor or is this work supported by your employeer?

[derberg]

they are there by default, just bet some fixes need to be done

so I will roll out basic configurations, CI, branch protection and other stuff like that

I will review what you have and open PR with fixes

[GreenRover]

Any updates?

[derberg]

@GreenRover there were several PRs from bot merged with some typical changes, code of conduct sync, and other workflows. I also created asyncapi/protobuf-schema-parser#11 to make this new repo follow the latest release pipelines.

[GreenRover]

Release 1.0 was published! Thanks. Do you have an idea why npm.com is not accepting the readme: https://www.npmjs.com/package/@asyncapi/protobuf-schema-parser

[derberg]

@GreenRover I think we have everything needed. Repo setup, project released, CI and config there, 2 maintainers appointed.

if you need anything, you need where to find me 😄

if you want to join technical steering committee please open PR against this file https://github.com/asyncapi/community/blob/master/TSC_MEMBERS.json. I strongly recommend that if a colleague of yours is also interested, he should first join slack, get familiar with community, join some calls and then really join the community as TSC member

[smoya]

Can we close this as done? https://github.com/asyncapi/protobuf-schema-parser @GreenRover @derberg