Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): modelina playground theme rendering fixed #2164

Merged
merged 9 commits into from
Jan 28, 2025

Conversation

Shriya-Chauhan
Copy link
Contributor

Description

Theme rendering is fixed

Related Issue

#2163

Checklist

  • The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

Additional Notes

Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit ede2381
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/6798e2ca4ab3ca000866175e

@coveralls
Copy link

coveralls commented Jan 27, 2025

Pull Request Test Coverage Report for Build 13012067946

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.397%

Totals Coverage Status
Change from base Build 13012063557: 0.0%
Covered Lines: 6473
Relevant Lines: 6868

💛 - Coveralls

@Shriya-Chauhan Shriya-Chauhan changed the title fix : modelina playground theme rendering fixed fix: modelina playground theme rendering fixed Jan 27, 2025
@jonaslagoni jonaslagoni changed the title fix: modelina playground theme rendering fixed website: modelina playground theme rendering fixed Jan 27, 2025
@jonaslagoni
Copy link
Member

Nice 👌 @devilkiller-ag can you have a look?

I am gonna merge #2162 first though 🙂

/dnm

@jonaslagoni jonaslagoni changed the title website: modelina playground theme rendering fixed chore(website): modelina playground theme rendering fixed Jan 27, 2025
Copy link
Member

@devilkiller-ag devilkiller-ag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! The failing blackbox test is not related to this PR so we can ignore it for now.

@jonaslagoni jonaslagoni merged commit 69e49c9 into asyncapi:master Jan 28, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants