Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Missing server.title() function #1075

Open
2 tasks done
fmvilas opened this issue Jan 23, 2025 · 5 comments · May be fixed by #1081
Open
2 tasks done

[BUG] Missing server.title() function #1075

fmvilas opened this issue Jan 23, 2025 · 5 comments · May be fixed by #1081
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@fmvilas
Copy link
Member

fmvilas commented Jan 23, 2025

Describe the bug.

The Server Object doesn't have a way to access the title attribute of a server.

Expected behavior

We should have a function called .title() in the Server Object.

Screenshots

No screenshots.

How to Reproduce

Not relevant.

🥦 Browser

None

👀 Have you checked for similar open issues?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

No, someone else can work on it
@fmvilas fmvilas added the bug Something isn't working label Jan 23, 2025
@github-actions GitHub Actions
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@fmvilas fmvilas added the good first issue Good for newcomers label Jan 23, 2025
@fmvilas fmvilas transferred this issue from asyncapi/parser-api Jan 23, 2025
@fmvilas
Copy link
Member Author

fmvilas commented Jan 23, 2025

Apologies, I created this issue in the parser-api repo thinking this was not in the spec but it actually is there. It's a bug of the JS parser.

@Vineet1101
Copy link

@fmvilas so its still need to be done??

@Manudies
Copy link

I'm going to try.

@fmvilas
Copy link
Member Author

fmvilas commented Jan 24, 2025

In case someone is interested, there's a very similar issue: #1076. Same but with summary instead of title.

@shwetd19 shwetd19 mentioned this issue Jan 24, 2025
Open
AlexiusTatius added a commit to AlexiusTatius/parser-js that referenced this issue Feb 1, 2025
@AlexiusTatius
Fix asyncapi#1075: Added server.title() hasTitle() functions
92c1b72 
- title(): returns the server title string or undefined
- hasTitle: returns boolean indicating if title exists
- added the unit tests for the respective functions
- tested the code by building, ensuring changes in esm, cjs
@AlexiusTatius AlexiusTatius linked a pull request Feb 1, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(server): added server.title() and hasTitle() functions AlexiusTatius/parser-js
3 participants
@fmvilas @Manudies @Vineet1101