Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: center filter alignment on large screen #3630

Merged

Conversation

KishanInnovates
Copy link
Contributor

@KishanInnovates KishanInnovates commented Jan 30, 2025

Problem

  • The filter component was aligned to the left on large screens (lg:justify-start).

Solution

  • Changed lg:justify-start to lg:justify-center to properly center it.

Issue Link

Summary by CodeRabbit

  • Style
    • Updated filter section layout in Blog page to center-align on large screens
    • Reordered CSS classes in Community page's main container div for consistent styling

Copy link
Contributor

coderabbitai bot commented Jan 30, 2025

Walkthrough

The pull request addresses a layout alignment issue for filter components on large screens. In the pages/blog/index.tsx file, the className for the filter section has been changed from lg:justify-start to lg:justify-center to center-align the filters. Additionally, in the pages/community/index.tsx file, there's a minor reordering of CSS classes for a div element, which doesn't impact the functional behavior of the component.

Changes

File Change Summary
pages/blog/index.tsx Modified filter section layout to center-align on large screens
pages/community/index.tsx Reordered CSS classes for a div element without changing functionality

Assessment against linked issues

Objective Addressed Explanation
Center filter component on large screens [#3626]

Possibly related PRs

Suggested labels

ready-to-merge

Suggested reviewers

  • derberg
  • magicmatatjahu
  • devilkiller-ag
  • sambhavgupta0705
  • anshgoyalevil
  • Mayaleeeee
  • akshatnema

Poem

🐰 A rabbit's tale of pixels aligned,
Filters dancing, perfectly designed,
From left to center, a graceful leap,
Responsive magic, no more to weep!
Code flows smooth, with layout so bright,
Centered and balanced, a developer's delight! 🎨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bca2a91 and 5318d57.

📒 Files selected for processing (2)
  • pages/blog/index.tsx (1 hunks)
  • pages/community/index.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • pages/blog/index.tsx
⏰ Context from checks skipped due to timeout of 180000ms (4)
  • GitHub Check: Redirect rules - asyncapi-website
  • GitHub Check: Header rules - asyncapi-website
  • GitHub Check: Pages changed - asyncapi-website
  • GitHub Check: Lighthouse CI
🔇 Additional comments (1)
pages/community/index.tsx (1)

184-184: LGTM! But verify relevance to PR objective.

The reordering of CSS classes improves readability by grouping related properties together. However, this change appears unrelated to the PR's objective of fixing filter alignment on large screens.

Could you clarify how this change relates to the PR's objective of fixing the filter alignment issue? If it's unrelated, consider submitting it as a separate PR to maintain clear change history.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 72e7391
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/679f674fc2692f000833fd5b
😎 Deploy Preview https://deploy-preview-3630--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8993195) to head (72e7391).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #3630   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          732       732           
=========================================
  Hits           732       732           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asyncapi-bot
Copy link
Contributor

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 40
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-3630--asyncapi-website.netlify.app/

@KishanInnovates
Copy link
Contributor Author

@asyncapi-bot @anshgoyalevil Can you review this?

@anshgoyalevil
Copy link
Member

I see the issue was still awaiting triage when you created the PR. Kindly follow the contributing guidelines to understand when to create a PR.
Merging this, but please be mindful about it the next time.

@anshgoyalevil
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit ae25e36 into asyncapi:master Feb 2, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Filter Alignment Issue on Large Screen
3 participants