-
-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update tools.json #3642
chore: update tools.json #3642
Conversation
WalkthroughThis pull request updates three configuration files. In config/all-tags.json, color values for various technology entries are unified. config/tools-automated.json sees several tool entries reintroduced and added—including new API tools and modifications to generator template names—while config/tools.json is entirely refreshed with updated entries across multiple categories. There are no schema changes or functional modifications to exported entities. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3642 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 732 732
=========================================
Hits 732 732 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🔭 Outside diff range comments (3)
config/tools-automated.json (3)
757-775
: Critical Issue: "Java Template" Language Field MismatchThe "Java Template" incorrectly lists its language as
["javascript"]
even though the title and context indicate it is a Java template. This should likely be updated to["Java"]
.- "language": [ - "javascript" - ], + "language": [ + "Java" + ],
795-814
: Critical Issue: "Java Spring Cloud Stream Template" Language Field MismatchThe language for this template is set as
["javascript"]
, which does not match the Java-focused nature of the tool. Please update this to["Java"]
to maintain consistency.- "language": [ - "javascript" - ], + "language": [ + "Java" + ],
816-836
: Critical Issue: "Java Spring Template" Language Field InconsistencyThe "Java Spring Template" also specifies
"language": ["javascript"]
. To accurately reflect its intended usage, update the language to["Java"]
.- "language": [ - "javascript" - ], + "language": [ + "Java" + ],
🧹 Nitpick comments (3)
config/tools-automated.json (3)
119-136
: Addition of "nestjs-asyncapi" Entry in Code-first ToolsThis new tool enables AsyncAPI document generation via decorators similar to
@nestjs/swagger
. However, note that the"language"
field is set as"Typescript"
. For consistency with other entries (e.g., using"TypeScript"
), please consider updating the capitalization.- "language": "Typescript", + "language": "TypeScript",
409-424
: Addition: "GitHub Action for Generator" EntryA new GitHub Action for the generator has been added. Although the
"description"
is set to null, which might be intentional, consider providing a short description to clarify its purpose.
464-483
: New Mocking and Testing Tool: "Specmatic" AdditionThe Specmatic entry is detailed with clear links and a useful description. One minor note: the
"language"
field is listed as"kotlin"
. For consistency, consider capitalizing it as"Kotlin"
.- "language": "kotlin", + "language": "Kotlin",
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
config/all-tags.json
(1 hunks)config/tools-automated.json
(13 hunks)config/tools.json
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- config/tools.json
⏰ Context from checks skipped due to timeout of 180000ms (5)
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Lighthouse CI
🔇 Additional comments (11)
config/all-tags.json (1)
1-1
: Uniform Color Updates for Tags ConfigurationThe file now uniformly applies new background (
bg-[#61d0f2]
) and border (border-[#40ccf7]
) color values to a number of technology entries. This improves visual consistency across the application. Please double-check that these new color values are fully aligned with your design guidelines.config/tools-automated.json (10)
27-46
: New API Tool: "AsyncAPI Server API" AdditionThe new entry for "AsyncAPI Server API" has been added with proper links, a clear description, and appropriate filter settings (notably setting
"isAsyncAPIOwner": true
). This change aligns with the overall update objectives.
97-117
: Addition of "Zod Sockets" Entry in Code-first ToolsThe entry for "Zod Sockets" is clearly defined with accurate links and filter settings (using TypeScript with Node.js). The description and categorization accurately reflect its purpose.
161-175
: New Code Generator: "Golang AsyncAPI Code Generator" AdditionThe tool for generating Go boilerplate code from AsyncAPI specifications has been added with a clear description and appropriate filter settings. The details here are well structured.
197-222
: Addition of "ZenWave SDK" in Code GeneratorsThe "ZenWave SDK" entry is added with detailed links and a comprehensive set of filters. Please verify that the provided categorization (listing it under
"code-generator"
,"dsl"
,"mocking-and-testing"
, and"cli"
) precisely reflects the tool’s functionalities.
311-332
: Duplicate Entry for "Zod Sockets" in DSL SectionThe same "Zod Sockets" tool is listed again under the DSL category. If this duplication is intentional (to have the tool appear under multiple categories), a clarifying comment might help future maintainers. Otherwise, consider consolidating the entry.
364-380
: New Framework Entry: "Glee" AddedThe "Glee" entry has been introduced in the Frameworks section with a friendly description and correct filter settings. The flag
"isAsyncAPIOwner": true
is appropriately set.
426-440
: Addition: "GitHub Action for CLI" EntryThe "GitHub Action for CLI" entry is well defined, including comprehensive links and filter settings. This entry integrates smoothly with the rest of the GitHub Actions tools.
603-621
: Addition of "AsyncAPI CLI" in CLIs SectionThe new "AsyncAPI CLI" entry is incorporated with a complete set of details and proper filter settings. However, note that a similar entry exists under the "Others" category later in the file. Please confirm whether this duplicate listing is intentional.
720-737
: New Template: "Node.js Multiprotocol Template" AdditionThis template entry is well structured with clear language and technology settings. The entry appears to fulfill its role in the generator templates.
843-859
: Duplicate "AsyncAPI CLI" Entry in Others CategoryThe "AsyncAPI CLI" entry appears again in the Others section. Verify whether maintaining duplicate listings in both the CLIs and Others sections is intentional. If not, consider consolidating these entries for clarity.
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
This release includes visual updates and expanded resource listings that enhance user experience and consistency.