-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convertor keeps both files around? #16
Comments
I was thinking the same thing. Indeed, I don't see any purpose for mlpackage file in our use-case atm. For now, I think it's safe to delete that file. I don't want to bloat the interface with additional option (it seems a bit crowded as it is). I will change that in some future update. |
ya definitly feels like cleaning up the intermediate is safe |
Hi, i just doing the conversion from realistic vision with target size 512x768,original,cpu and gpu, the result is only .mlpackage but maybe because of error :
is something not installed in my mac ? Thanks |
Ok after I investigate further the command 'xcrun coremlcompiler compile' that makes that errors. How to install "coremlcompiler" ? |
did you have xcode installed when you installed the plugin? |
@cchance27 Yes I did, so I was surprised why its not working. Hope it can help someone |
@x4080 |
@aszc-dev already solved it thanks, it was xcode problem |
I noticed the convertor is keeping the mlpackage and models around after conversion, shouldn't the convertor drop the prelude file to save space (maybe an option in the node to keep the uncompiled version, as with each size needing a model, having 2x the files adds up quick.
Technically we end up with 3x models, the modelc the mlpackage and the safe tensor, would be nice to make keeping that middle one optional, and by default to just remove it after compilation.
The text was updated successfully, but these errors were encountered: