Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convertor keeps both files around? #16

Open
cchance27 opened this issue Nov 19, 2023 · 8 comments
Open

Convertor keeps both files around? #16

cchance27 opened this issue Nov 19, 2023 · 8 comments

Comments

@cchance27
Copy link
Contributor

I noticed the convertor is keeping the mlpackage and models around after conversion, shouldn't the convertor drop the prelude file to save space (maybe an option in the node to keep the uncompiled version, as with each size needing a model, having 2x the files adds up quick.

Technically we end up with 3x models, the modelc the mlpackage and the safe tensor, would be nice to make keeping that middle one optional, and by default to just remove it after compilation.

@aszc-dev
Copy link
Owner

I was thinking the same thing. Indeed, I don't see any purpose for mlpackage file in our use-case atm. For now, I think it's safe to delete that file. I don't want to bloat the interface with additional option (it seems a bit crowded as it is). I will change that in some future update.

@cchance27
Copy link
Contributor Author

ya definitly feels like cleaning up the intermediate is safe

@x4080
Copy link

x4080 commented Nov 30, 2023

Hi, i just doing the conversion from realistic vision with target size 512x768,original,cpu and gpu, the result is only .mlpackage

but maybe because of error :

xcrun: error: unable to find utility "coremlcompiler", not a developer tool or in PATH
ERROR:root:!!! Exception during processing !!!

is something not installed in my mac ?

Thanks

@x4080
Copy link

x4080 commented Nov 30, 2023

Ok after I investigate further the command 'xcrun coremlcompiler compile' that makes that errors. How to install "coremlcompiler" ?

@cchance27
Copy link
Contributor Author

did you have xcode installed when you installed the plugin?

@x4080
Copy link

x4080 commented Dec 1, 2023

@cchance27 Yes I did, so I was surprised why its not working. Hope it can help someone

@aszc-dev
Copy link
Owner

aszc-dev commented Dec 3, 2023

@x4080
I don't know if you're still facing this issue, but if you are, there's an easy solution described in this article (It's in the last paragraph of Model Conversion section). Perhaps this could help?

@x4080
Copy link

x4080 commented Dec 4, 2023

@aszc-dev already solved it thanks, it was xcode problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants