From 4023f3d220c30f49b45bd4ca918cdb65a670ae8b Mon Sep 17 00:00:00 2001 From: bgvozdev <20631664+bgvozdev@users.noreply.github.com> Date: Wed, 1 Nov 2023 12:57:29 +1100 Subject: [PATCH] NONE: remove FF (#2527) --- src/config/feature-flags.ts | 1 - src/routes/jira/jira-get.ts | 2 -- views/jira-configuration.hbs | 2 -- views/partials/jira-configuration-table.hbs | 8 -------- 4 files changed, 13 deletions(-) diff --git a/src/config/feature-flags.ts b/src/config/feature-flags.ts index 4eb4c3d5c..29b7880bf 100644 --- a/src/config/feature-flags.ts +++ b/src/config/feature-flags.ts @@ -23,7 +23,6 @@ export enum BooleanFlags { LOG_CURLV_OUTPUT = "log-curlv-output", ENABLE_SUBSCRIPTION_DEFERRED_INSTALL = "enable-subscription-deferred-install", EARLY_EXIT_ON_VALIDATION_FAILED = "early-exit-on-validation-failed", - ENABLE_CONNECTED_REPOS_VIEW="enable-connected-repos-view", USE_REST_API_FOR_DISCOVERY = "use-rest-api-for-discovery-again", ENABLE_GITHUB_SECURITY_IN_JIRA = "enable-github-security-in-jira", DELETE_MESSAGE_ON_BACKFILL_WHEN_OTHERS_WORKING_ON_IT = "delete-message-on-backfill-when-others-working-on-it", diff --git a/src/routes/jira/jira-get.ts b/src/routes/jira/jira-get.ts index d7a24aa79..9ce582dd0 100644 --- a/src/routes/jira/jira-get.ts +++ b/src/routes/jira/jira-get.ts @@ -5,7 +5,6 @@ import { GitHubServerApp } from "models/github-server-app"; import { sendAnalytics } from "utils/analytics-client"; import { AnalyticsEventTypes, AnalyticsScreenEventsEnum } from "interfaces/common"; import { Errors } from "config/errors"; -import { booleanFlag, BooleanFlags } from "config/feature-flags"; import { countNumberSkippedRepos, countStatus, @@ -71,7 +70,6 @@ const renderJiraCloudAndEnterpriseServer = async (res: Response, req: Request): hasCloudServers: !!(successfulCloudConnections.length || failedCloudConnections.length), hasConnections, APP_URL: process.env.APP_URL, - enableRepoConnectedPage: await booleanFlag(BooleanFlags.ENABLE_CONNECTED_REPOS_VIEW, jiraHost), csrfToken: req.csrfToken(), nonce }); diff --git a/views/jira-configuration.hbs b/views/jira-configuration.hbs index 4bf8e49ec..b202c28fe 100644 --- a/views/jira-configuration.hbs +++ b/views/jira-configuration.hbs @@ -195,7 +195,6 @@ csrfToken=csrfToken successfulConnections=ghCloud.successfulCloudConnections failedConnections=ghCloud.failedCloudConnections - enableRepoConnectedPage=enableRepoConnectedPage }} @@ -273,7 +272,6 @@ successfulConnections=app.successfulConnections failedConnections=app.failedConnections gitHubAppId=app.id - enableRepoConnectedPage=../../enableRepoConnectedPage }} {{else}}
diff --git a/views/partials/jira-configuration-table.hbs b/views/partials/jira-configuration-table.hbs index 1d2194e06..02e8edbfa 100644 --- a/views/partials/jira-configuration-table.hbs +++ b/views/partials/jira-configuration-table.hbs @@ -34,7 +34,6 @@ {{! Repos Synced }} - {{#if ../enableRepoConnectedPage}} {{#if connection.isGlobalInstall}} All repos @@ -42,13 +41,6 @@ Only select repos {{/if}} - {{else}} - {{#if connection.isGlobalInstall}} - All repos - {{else}} - Only select repos - {{/if}} - {{/if}} {{#if (checkRepoCount connection.totalNumberOfRepos)}}