Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Molar Masses #78

Open
C130PA5 opened this issue Jan 11, 2024 · 3 comments
Open

Wrong Molar Masses #78

C130PA5 opened this issue Jan 11, 2024 · 3 comments
Assignees

Comments

@C130PA5
Copy link

C130PA5 commented Jan 11, 2024

I don't know if this repository is still used and updated. However, I noticed that molar masses in the chem_edgar.R file are wrong.

@ibarraespinosa
Copy link
Member

Hi @C130PA5 , thanks for catching up that error. Maybe you can post the molar mass here, or you can provide a pull request and I can add you as contributor

@C130PA5
Copy link
Author

C130PA5 commented Jan 23, 2024

For SO2, the total molar mass is 64 however in the code it is 64+16*2. This occurs in the entire file.
Example:
E_SO2 <- bp$so2 / (64 + 16 * 2) # emis_opt$eradm[2]
E_NO <- bp$nox * 0.9 / (14 + 16) # emis_opt$eradm[3]
E_CO <- bp$co / (12 + 18) # emis_opt$eradm[4]

@ibarraespinosa
Copy link
Member

ibarraespinosa commented Jan 23, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants