Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling device availability is not consistent #239

Open
ScottDaniels opened this issue Jan 17, 2018 · 0 comments
Open

Handling device availability is not consistent #239

ScottDaniels opened this issue Jan 17, 2018 · 0 comments
Labels

Comments

@ScottDaniels
Copy link
Contributor

During initialisation the number of ports reported by DPDK is checked with what is expected in the config file and errors/warnings are issued based on what is expected vs what is found. If less ports are available than expected a warning is issued and execution continues. If more ports are reported than expected a critical message, indicating abort is to be performed, is written, but the abort doesn't happen.

This section of main.c needs to be examined and cleaned up. My suggestion is to issue a critical error and abort if the number of reported devices does NOT match the number of devices in the config as we have specifically whitelisted all of the devices in the config and if one is missing that is not a state that I think we should continue with.

Code in main.c is about line 1598.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant