Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only load refresh token in configure() when sessionType=refresh_token #336

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Only load refresh token in configure() when sessionType=refresh_token #336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions packages/authgear-web/src/container.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,10 +277,6 @@ export class WebContainer {
* @public
*/
async configure(options: ConfigureOptions): Promise<void> {
// TODO: verify if we need to support configure for second time
// and guard if initialized
const refreshToken = await this.tokenStorage.getRefreshToken(this.name);

this.clientID = options.clientID;
this.baseContainer.apiClient.endpoint = options.endpoint;
if (options.sessionType != null) {
Expand All @@ -294,16 +290,20 @@ export class WebContainer {
this.isSSOEnabled = options.isSSOEnabled ?? false;
}

this.baseContainer.refreshToken = refreshToken ?? undefined;

switch (this.sessionType) {
case "cookie":
this.baseContainer._updateSessionState(
SessionState.Unknown,
SessionStateChangeReason.NoToken
);
break;
case "refresh_token":
case "refresh_token": {
// Only load refresh token when the session type is refresh_token.
// This prevents a very rare situation that session type is changed from refresh_token to cookie,
// and the previously stored refresh token is loaded.
const refreshToken = await this.tokenStorage.getRefreshToken(this.name);
this.baseContainer.refreshToken = refreshToken ?? undefined;

if (this.baseContainer.refreshToken != null) {
// consider user as logged in if refresh token is available
this.baseContainer._updateSessionState(
Expand All @@ -317,6 +317,7 @@ export class WebContainer {
);
}
break;
}
}
}

Expand Down