-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka seekTImestamp should also support timestamp in 2024-01-29T19:35:21.959
format
#621
Comments
@authorjapps In addition to this, do you think out of the box, doing something like: Then we can generate the timestamp to consume from on a previous step? |
Hello @a1shadows , I suggest you please pick this after your other PR is done or at least after it comes to a logical end. Ok, now to answer your query, let me try to explain: The problem is, your current PR implementation may not work(or may work once you complete the full implementation) for timestamps other than ECPOCH time in long/integer format. This ticket #621 was raised to support the below format as well, so that we allow EPOCH as well as the standard format i.e. If your current PR will allow both formats, I think we can simply close this ticket #621 without further spedning time on this. |
@authorjapps I can definitely incorporate this into my PR, but I have a concern here. If we want to support formatted strings, for instance 'yyyy-MM-dd'T'HH:mm:ss.SSS' should we not be taking the pattern as input as well along with the actual timestamp? Or will we only support one pattern? Or would it be better to make LOCAL.DATETIME.NOW support epoch format as well? |
@a1shadows, Good question mate 👍 I think it would be better the below way, if you can accommodate in your PR please. e.g.
I suggest you implement this |
@authorjapps I think we can close this as well |
Closed by #615 |
Related to Issue #615
The below TODO after #615 is done
Support The Following also:
AC1:
So, provide the mechanism to get the Long epoch value inferred from the datetimestamps formated values:
e.g.
The following also should be acceptable to the framework:
So we need to support all of the above usages.
Actually points 2 and 3 will work identical way once implemented.
The text was updated successfully, but these errors were encountered: