Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH-DEBT] Add an Integration test scenario with multi partition topic to reproduce NPE for seekTimestamp feature #633

Closed
authorjapps opened this issue Mar 1, 2024 · 0 comments

Comments

@authorjapps
Copy link
Owner

authorjapps commented Mar 1, 2024

          > @authorjapps have added an init container that will create a multi partition topic to run the test against.

Ideally we should change the num.partitions setting in the kafka broker, but can't find a way to do that in the cp-kafka image we have used. Let me know your thoughts

ok. Let's figure out this in the coming days.

Also,
if you have tested locally in your Kafka cluster that everything works as expected, then we should be fine for now.
I will raise a TECH-DEBT to get a Integration test added to our CI suite to cover this PARTITION->OFFSET NPE scenario.

Let's get this merged anyways.

Originally posted by @authorjapps in #630 (comment)


Note:
Go through the entire conversation on the PR prior to picking this issue and fixing it.
PR Link: #630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants