Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seek kafka improvements, CI fixed #646

Merged
merged 5 commits into from
Mar 18, 2024
Merged

seek kafka improvements, CI fixed #646

merged 5 commits into from
Mar 18, 2024

Conversation

a1shadows
Copy link
Collaborator

@a1shadows a1shadows commented Mar 14, 2024 •
edited
Loading

Fixes Issue

PR Branch
#ADD LINK TO THE PR BRANCH

Motivation and Context

Fixed issues in the CI where creation of multiple partition topics was not working correctly.
Handled edge cases around the seek timestamp mechanism and added more tests to verify the same.

Checklist:

  • Unit tests added

  • Integration tests added

  • Test names are meaningful

  • Feature manually tested

  • Branch build passed

  • No 'package.*' in the imports

  • Relevant Wiki page updated with clear instruction for the end user

    • Not applicable. This was only a refactor change, no functional or behaviour changes were introduced

  • Http test added to http-testing module(if applicable) ?

    • Not applicable. The changes did not affect HTTP automation flow

  • Kafka test added to kafka-testing module(if applicable) ?

    • Not applicable. The changes did not affect Kafka automation flow

@a1shadows a1shadows marked this pull request as ready for review March 14, 2024 05:49
@a1shadows a1shadows changed the title seek kafka improvements seek kafka improvements, CI fixed Mar 14, 2024
@a1shadows a1shadows requested a review from authorjapps March 14, 2024 05:49
@a1shadows
Copy link
Collaborator Author

@authorjapps Could you take a look at this?

@authorjapps
Copy link
Owner

@authorjapps Could you take a look at this?

Yep, will have a look soon. As always, thanks for taking a deeper look at the seek issue.

@a1shadows a1shadows merged commit 5e440fa into authorjapps:master Mar 18, 2024
1 check passed
@a1shadows a1shadows deleted the seek-improve branch March 25, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@authorjapps authorjapps authorjapps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvement of seek functionality in kafka consumer
2 participants
@a1shadows @authorjapps