Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MDL : Improved unit test coverage #1111

Open
bernardkwok opened this issue Feb 10, 2021 · 0 comments
Open

MDL : Improved unit test coverage #1111

bernardkwok opened this issue Feb 10, 2021 · 0 comments
Labels
Infrastructure ShaderGen Shader Generation change required
Milestone
1.39

Comments

@bernardkwok
Copy link

Seems some definitions are not being tested and additional tests should be added as needed to test shader generation

  • constants
  • switch nodes
  • other?
@bernardkwok bernardkwok added ShaderGen Shader Generation change required Infrastructure labels Feb 10, 2021
@bernardkwok bernardkwok added this to the 1.39 milestone Feb 10, 2021
@bernardkwok bernardkwok modified the milestones: 1.39, 1.38 Feb 10, 2021
@bernardkwok bernardkwok modified the milestones: 1.38, 1.39 Mar 18, 2021
ashwinbhat pushed a commit that referenced this issue Nov 8, 2022
@rasmusbonnedal
Fix implementation of screen node (#1111)
1b79589 
The parentheses were incorrectly placed in the implementation of the screen compositing node.

Changes from this:
    (mix * ((1 - (1 - fg)) * (1 - bg))) + ((1 - mix) * bg)

to this:
    (mix * ((1 - (1 - fg) * (1 - bg)))) + ((1 - mix) * bg)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Infrastructure ShaderGen Shader Generation change required
Projects
None yet
Milestone
1.39
Development

No branches or pull requests
1 participant
@bernardkwok