Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShaderGen should allow uniform declarations with initialization #1239

Open
bernardkwok opened this issue Jun 21, 2021 · 0 comments
Open

ShaderGen should allow uniform declarations with initialization #1239

bernardkwok opened this issue Jun 21, 2021 · 0 comments
Assignees
@bernardkwok
Labels
ShaderGen Shader Generation change required
Milestone
1.39

Comments

@bernardkwok
Copy link

bernardkwok commented Jun 21, 2021 •
edited
Loading

This is a request based on the fact that a shading language may not allow for initialization of a uniform
as part of the declaration. It is also useful for code reuse if the shader code itself is used to determine uniqueness for
reuse (say to to avoid shader recompilation)

The proposal is to add in a generation option settable can be set before generation is requested. It would apply to all generators, including OSL and MDL. Here it would be a main function argument initialization option.
@bernardkwok bernardkwok added this to the 1.39 milestone Jun 21, 2021
@bernardkwok bernardkwok added the ShaderGen Shader Generation change required label Jun 21, 2021
@bernardkwok bernardkwok self-assigned this Jun 21, 2021
ashwinbhat pushed a commit that referenced this issue Feb 25, 2023
@jstone-lucasfilm
Simplifications to editor headers (#1239)
081e7e5 
This changelist simplifies the header files in MaterialXGraphEditor, with no changes to editor logic or behavior.

- Remove a bidirectional dependency between Graph.h and UiNode.h, moving the UiEdge class class from Graph.h to UiNode.h.
- Move include directives from headers to source code where possible.
- Remove unused include directives where possible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bernardkwok bernardkwok

Labels
ShaderGen Shader Generation change required
Projects
None yet
Milestone
1.39
Development

No branches or pull requests
1 participant
@bernardkwok