Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tables Aren't Sortable #1

Closed
dlbucci opened this issue Oct 27, 2014 · 4 comments
Closed

Tables Aren't Sortable #1

dlbucci opened this issue Oct 27, 2014 · 4 comments
Assignees
@jez

Comments

@dlbucci
Copy link
Member

dlbucci commented Oct 27, 2014

The manage accounts page no longer sorts by column.
I think this has to do with us not including jQuery sorttables in the application layout. instead, we should include it on any page with a table.
@kidouchi
Copy link

Hi,
Do you mind if I look into this? I have experience with jQuery, so I may be able to implement this...

@icanb
Copy link
Member

icanb commented Nov 12, 2014

Hey @kidouchi, Sure you can work on it! Let us know if you need any help. And please subscribe to this list: https://lists.andrew.cmu.edu/mailman/listinfo/autolab-os

@icanb icanb added the bug label Nov 12, 2014
@jez jez mentioned this issue Jan 15, 2015
Closed
jez referenced this issue in jez/Autolab Jan 16, 2015
@jez
Fix table sorting in Manage Accounts page. #1
354faf4 
I removed Prototype.js, which was shadowing jQuery, and then made a call
to the `sorttables` function, which adds listeners on the table headings
to toggle sorting.

Prototype.js doesn't look like it has a place in our code, from what I
can tell. Correct me if I'm wrong. I'll be attempting to remove it in
favor of jQuery whenever I get the chance. Until it's "safe," I'll be
preferring `jQuery(...)` over `$(...)`, even though this is generally
not the best style.

I also disabled the functionality to float table headers at the top of
the screen, because it was causing errors and the current "solution" was
really hacky. I might look into enabling this feature later.
@jez
Copy link
Contributor

jez commented Jan 16, 2015

At least on the Manage Accounts page, it looks like the error was being caused by not calling the sorttables() method after the DOM had loaded (or not at all). It's fixed on the Manage Accounts page, and it should be relatively simple to make any other tables sortable by following changes similar to those introduced in #105.

Since there are tons of tables in the app, it doesn't make economical sense to peck and hunt for all of them. I'll keep this issue open for a while until they gradually are all fixed. When a table is encountered that's not sortable, see #105 for boilerplate code to fix the issue.

@jez jez mentioned this issue Jan 16, 2015
Merged
dlbucci pushed a commit that referenced this issue Jan 16, 2015
Merge pull request #105 from Z1MM32M4N/fix_table_sorting
925304e 
Fix table sorting in Manage Accounts page. #1
@ymzong
Copy link
Member

ymzong commented Jan 21, 2015

Fixed by 05d067f.

@ymzong ymzong closed this as completed Jan 21, 2015
@damianhxy damianhxy mentioned this issue Aug 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jez jez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@icanb @kidouchi @ymzong @dlbucci @jez