TmpNet on Local Networks #2576
TmpNet on Local Networks #2576
Conversation
felipemadero
requested review from
sukantoraymond,
arturrez and
meaghanfitzgerald
|
✅ Deployed a Subnet (--sovereign=false) Will do additional code review, but functionally tmpnet seems to be working, and feels a bit faster than ANR |
There was a problem hiding this comment.
this is a massive PR, definitely would help to get a review of the tmpnet implementation from @maru-ava if you're willing 🙏
cmd/networkcmd/start.go
Outdated
|
|
||
| "github.com/ava-labs/avalanche-cli/pkg/interchain" | ||
| "github.com/ava-labs/avalanche-cli/pkg/localnet" | ||
| "github.com/ava-labs/avalanche-cli/pkg/models" | ||
| "github.com/ava-labs/avalanche-cli/pkg/networkoptions" | ||
| "github.com/ava-labs/avalanche-cli/pkg/node" | ||
| "github.com/ava-labs/avalanche-cli/pkg/subnet" | ||
| "github.com/ava-labs/avalanche-cli/pkg/utils" | ||
|
|
There was a problem hiding this comment.
why the added spaces on 15 and 21?
Co-authored-by: Meaghan FitzGerald <[email protected]> Signed-off-by: felipemadero <[email protected]>
|
Currently on main, if i deploy a subnet in local network (ANR, sovereign=false), and then create another subnet and deploy in local network again, it works fine. On tmpnet, if i deploy a subnet in local network (tmpnet, sovereign=false), and then create another subnet and deploy in local network again: |
|
running network clean after, and try deploying again: and then running network stop: |
| app.Log.Warn("failed killing server process", zap.Error(err)) | ||
| } else { | ||
| ux.Logger.PrintToUser("Process terminated.") | ||
| if err := localnet.LocalNetworkStop(app); err != nil && !errors.Is(err, localnet.ErrNetworkNotBootstrapped) { |
There was a problem hiding this comment.
Currently on main, if network clean is successful it prints out
Process terminated.
We should print out something if clean is successful.
| binutils.WithDialTimeout(constants.FastGRPCDialTimeout), | ||
| ) | ||
| // Returns true if all local network nodes are alive | ||
| func LocalNetworkIsBootstrapped(app *application.Avalanche) (bool, error) { |
There was a problem hiding this comment.
can differentiate between the names LocalNetworkIsBootstrapped and IsLocalNetworkBlockchainBootstrapped
Why this should be merged
Closes #2509 #2510 #2511
Replaces ANR with TmpNet for implementation of local network deploys.
How this works
How this was tested
How is this documented