Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add automated checks for syncing with base repository (wip) #88

Open
2 of 4 tasks
qdm12 opened this issue Dec 12, 2024 · 1 comment
Open
2 of 4 tasks

chore: add automated checks for syncing with base repository (wip) #88

qdm12 opened this issue Dec 12, 2024 · 1 comment

Comments

@qdm12
Copy link
Collaborator

qdm12 commented Dec 12, 2024

Rationale

Since syncing this repository with github.com/ethereum/go-ethereum will be rather complex, especially the first time, we may overlook some small elements such as import names. It would be nice to have CI checks to improve the certainty the syncing was done properly. The following list is a work-in-progress and I plan to add more as I get more familiar with the project.

Implementation

  • Check every import statements uses github.com/ava-labs/libevm instead of github.com/ethereum/go-ethereum done by .github/workflows/rename-module.yml
  • Check go.mod module name stays github.com/ava-labs/libevm done by .github/workflows/rename-module.yml
  • Check CI steps Go version matches the go.mod version of the repository
  • Use golangci-lint's option new-from-rev: HEAD where HEAD is set automatically to the base fork commit
@qdm12 qdm12 changed the title Add automated checks for syncing with base repository Add automated checks for syncing with base repository (wip) Dec 12, 2024
@ARR4N
Copy link
Collaborator

ARR4N commented Dec 12, 2024

Thanks for thinking through this; automation is really important for safety so I'm glad to see that that's where your ideas are focussed.

  • Check every import statements uses github.com/ava-labs/libevm instead of github.com/ethereum/go-ethereum
  • Check go.mod module name stays github.com/ava-labs/libevm

The first step of an upstream sync is to use this automated workflow, which already covers these two. Feel free to add more checks / smoke tests as you think of them.

@qdm12 qdm12 changed the title Add automated checks for syncing with base repository (wip) chore: add automated checks for syncing with base repository (wip) Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants