-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clock skew not being handled by didCompleteWithError method #1077
Comments
@ghearly Sorry for the inconvenience. Can you post a code snippet that reproduces the issue? |
@kvasukib This is the AWSAPIGatewayRequest we are using: We call it like this The APIClient class is generated by AWS, it works fine when the client has the correct hour and date set. |
The APIGatewayClient and its API-specific subclasses use custom network handling rather than the core stack, which means that even defining a retry handler and injecting it into the API client's configuration wouldn't be respected. The request returned from the API Gateway includes enough information that a caller could potentially inspect and retry manually, but that's not really a good solution--the SDK should do this on the client's behalf. Because the APIGateway network stack is custom, the behavior isn't technically a bug so much as a feature gap. Therefore, I'm characterizing this as a feature request to this capability to bring this SDK into parity with other SDKs. At implementation time, we'll need to decide whether to expand the client with retry-specific custom code in both |
We are also facing this issue. In IOS we implemented direct lambda invocation, when user changes iPads time manually got below exception And there is no proper solution for Clock skew issue in IOS. |
Thanks for opening this feature request. We’re closing this due to the lack of community engagement on the request. |
Describe the bug
When making a request on a device with wrong time, the response comes with the following error
Signature not yet current: 20130909T170846Z is still later than 20130909T170823Z (20130909T170323Z + 5 min.)
.To Reproduce
Steps to reproduce the behavior:
Which AWS service(s) are affected?
• AWSLambda
Expected behavior
When making a request on a device with wrong time, the SDK should attempt a new request with the clock skew fixed.
Screenshots
Not applicable.
Environment(please complete the following information):
Device Information (please complete the following information):
Additional context
When an error related to clock skew returns from the request it should call the method
- (void)URLSession:(NSURLSession *)session task:(NSURLSessionTask *)sessionTask didCompleteWithError:(NSError *)error
in order to retry the task with clock skew fixed (AWSNetworkingRetryTypeShouldCorrectClockSkewAndRetry
).The text was updated successfully, but these errors were encountered: