Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LambdaTestTool: Amazon.Lambda.AspNetCoreServer supports ApplicationLoadBalancerFunction but there is no test request for it. Support for HttpApi also needs to be added. #1084

Closed
ashishdhingra opened this issue Feb 18, 2022 · 2 comments
Closed

LambdaTestTool: Amazon.Lambda.AspNetCoreServer supports ApplicationLoadBalancerFunction but there is no test request for it. Support for HttpApi also needs to be added. #1084

ashishdhingra opened this issue Feb 18, 2022 · 2 comments
Labels
feature-request A feature should be added or improved. module/lambda-test-tool

Comments

@ashishdhingra
Copy link
Contributor

ashishdhingra commented Feb 18, 2022 •
edited
Loading

This is a follow up on creating a new issue while triaging #1075 (comment).

Add an example ALB request to the list of common request types. The Amazon.Lambda.AspNetCoreServer supports ApplicationLoadBalancerFunction but there is no test request for it. It would be a useful pull request to add a request like the example request provided in the documentation.

Per discussion with the team, support for HttpApi also needs to be added.
@ashishdhingra ashishdhingra added B feature-request A feature should be added or improved. module/lambda-test-tool labels Feb 18, 2022
@ashishdhingra ashishdhingra changed the title LambdaTestTool: Amazon.Lambda.AspNetCoreServer supports ApplicationLoadBalancerFunction but there is no test request for it. We also need to add support for HttpApi LambdaTestTool: Amazon.Lambda.AspNetCoreServer supports ApplicationLoadBalancerFunction but there is no test request for it. Support for HttpApi also needs to be added. Feb 18, 2022
@ashishdhingra ashishdhingra mentioned this issue Apr 4, 2022
Merged
@ashishdhingra
Copy link
Contributor Author

This has been added in Amazon.Lambda.TestTool-X.0 version 0.12.2.

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved. module/lambda-test-tool
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ashishdhingra