Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Connect Docker instance to multiple networks #7559

Open
marcoreni opened this issue Oct 11, 2024 · 2 comments
Open

Feature request: Connect Docker instance to multiple networks #7559

marcoreni opened this issue Oct 11, 2024 · 2 comments
Labels
type/feature Feature request

Comments

@marcoreni
Copy link

Describe your idea/feature/enhancement

In some complex scenarios (eg. using localstack with some other dependency) it may be useful to connect the Lambda with multiple Docker Networks.

Docker already supports the functionality of connecting one container to multiple networks, so it would just be a matter of exposing a new option so that a list of networks can be provided.

Proposal

Expose --docker-networks (or accept multiple --docker-network values).

Additional Details

@marcoreni marcoreni added stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. type/feature Feature request labels Oct 11, 2024
@mndeveci
Copy link
Contributor

Thanks for the recommendation @marcoreni,

sam local commands already exposes --docker-network parameter (see one example here), I assume your intention to define it multiple times so that it can be attached to multiple docker networks?

@mndeveci mndeveci removed the stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. label Oct 16, 2024
@marcoreni
Copy link
Author

That's correct! We're trying to use localstack but at the same time we have some external services that we'd like to connect to our lambdas. Right now we need to pass through host networking, but having multiple networks connected would be ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants