Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 URI parser #1507

Closed
dvirtz opened this issue Oct 29, 2020 · 7 comments
Closed

S3 URI parser #1507

dvirtz opened this issue Oct 29, 2020 · 7 comments
Labels
feature-request A feature should be added or improved. help wanted We are asking the community to submit a PR to resolve this issue. p3 This is a minor priority issue

Comments

@dvirtz
Copy link

dvirtz commented Oct 29, 2020

Is your feature request related to a problem? Please describe.
I'd like to parse S3 URI to get region, bucket, etc.

Describe the solution you'd like
A parser API like in .NET and Java

Describe alternatives you've considered
I can parse it manually but it might break sometime.
@dvirtz dvirtz added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 29, 2020
@KaibaLopez
Copy link
Contributor

Hi @dvirtz ,
This sounds like a reasonable enough feature request, I just don't know when we could get around to making it happen, we do take PRs though, in case you already have an idea on how to implement it.

@KaibaLopez KaibaLopez added help wanted We are asking the community to submit a PR to resolve this issue. and removed needs-triage This issue or PR still needs to be triaged. labels Nov 12, 2020
@dvirtz
Copy link
Author

dvirtz commented Nov 13, 2020

My idea is to reuse the parsing from Http::URI class and copy the other logic from the .NET and Java implementations. Does that sound ok?

@KaibaLopez
Copy link
Contributor

sounds good to me, could you try making a pr so we can review it?

@dvirtz
Copy link
Author

dvirtz commented Nov 25, 2020

started a PR at #1523

@dvirtz dvirtz mentioned this issue Nov 26, 2020
Closed
11 tasks
@ajaybhargavb
Copy link

@KaibaLopez any update on this? Almost every other language AWS Sdk contains this utility. I don't understand why the cpp sdk is lagging so far behind.

@jmklix jmklix added the p3 This is a minor priority issue label Mar 10, 2023
@jmklix
Copy link
Member

jmklix commented May 3, 2024

This is not something we plan on adding to the sdk. I would suggest using regex for this

@jmklix jmklix closed this as completed May 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved. help wanted We are asking the community to submit a PR to resolve this issue. p3 This is a minor priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ajaybhargavb @jmklix @dvirtz @KaibaLopez