Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typedefs for ClientConfiguration and EndpointProvider types in Client classes #2446

Closed
1 of 2 tasks
rwie-aws opened this issue Apr 18, 2023 · 3 comments
Closed
1 of 2 tasks
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.

Comments

@rwie-aws
Copy link
Contributor

rwie-aws commented Apr 18, 2023

Describe the feature

Add typedefs ClientConfigurationType and EndpointProviderType to service client classes.

Use Case

Makes it easier to use template functions to construct service clients while applying shared configuration values.

For example:

template<typename T>
std::shared_ptr<T> CreateAwsClient(const T::ClientConfigurationType& config) {
  auto config_ = config;
  config_.profile = "my_custom_profile";
  return std::make_shared<T>(config_);
}

Proposed Solution

Add the typedefs to the ServiceClient templates and regenerate the clients.

Other Information

This can currently be worked around by using deprecated constructors that take Aws::Client::ClientConfiguration instead of the service-specific configuration.

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@rwie-aws rwie-aws added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 18, 2023
rwie-aws added a commit to rwie-aws/aws-sdk-cpp that referenced this issue Apr 18, 2023
…ice clients

Implements the feature requested in issue aws#2446.
@jmklix
Copy link
Member

jmklix commented Apr 21, 2023

Thanks for opening this and making a PR. Reviewing the PR

@jmklix jmklix added pending-release This issue will be fixed by an approved PR that hasn't been released yet. p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Apr 21, 2023
SergeyRyabinin pushed a commit that referenced this issue May 2, 2023
…ice clients

Implements the feature requested in issue #2446.
SergeyRyabinin pushed a commit that referenced this issue May 3, 2023
…ice clients

Implements the feature requested in issue #2446.
sbiscigl pushed a commit that referenced this issue May 3, 2023
…ice clients

Implements the feature requested in issue #2446.
jmklix pushed a commit that referenced this issue Aug 11, 2023
…ice clients

Implements the feature requested in issue #2446.
@jmklix
Copy link
Member

jmklix commented May 17, 2024

Merged PR. Closing issue

@jmklix jmklix closed this as completed May 17, 2024
Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.
Projects
None yet
Development

No branches or pull requests

3 participants
@jmklix @rwie-aws and others