Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting either a custom domain or some kind of prefix (for PR Previews) #14

Open
acomito opened this issue Apr 25, 2022 · 3 comments

Comments

@acomito
Copy link

acomito commented Apr 25, 2022

Using this github action to deploy on a PR I can almost get PR Previews setup (like heroku, netlify, render, etc).

The only roadblock that I'm running into is I need to know the URL ahead of time-- I need a predictable URL.

If we could set the URL through the apprunner step, I have access to the PR number inside the github action so it would be easy to formulate a url to pass in pretty easily.

It seems like maybe I can create my own action/step in the mean time using the API?

https://docs.aws.amazon.com/apprunner/latest/api/API_AssociateCustomDomain.html

Otherwise, only other missing thing to match heroku etc would be shutting down a service when a PR get's closed

@acomito
Copy link
Author

acomito commented Apr 25, 2022

Just found this post which was interesting but requires using terraform: https://cdcloudlogix.com/from-heroku-review-apps-to-aws-app-runner/

@hariohmprasath
Copy link
Contributor

hariohmprasath commented Apr 26, 2022 via email

@gsogol
Copy link

gsogol commented Aug 26, 2022

Need custom domain as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants