From e7ce3a0a2d4536c7fa28f8276ed5bc2f00241f6e Mon Sep 17 00:00:00 2001 From: Alessandro Passaro Date: Mon, 25 Nov 2024 17:20:29 +0000 Subject: [PATCH] Remove old TODO (#1167) The issue has already been addressed in Cancel S3 requests when dropped [#794](https://github.com/awslabs/mountpoint-s3/pull/794). --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). Signed-off-by: Alessandro Passaro --- mountpoint-s3/src/fs.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/mountpoint-s3/src/fs.rs b/mountpoint-s3/src/fs.rs index efe236cb1..3120c1229 100644 --- a/mountpoint-s3/src/fs.rs +++ b/mountpoint-s3/src/fs.rs @@ -840,7 +840,6 @@ where let write_state = match file_handle.state.into_inner() { FileHandleState::Read { handle, .. } => { - // TODO make sure we cancel the inflight PrefetchingGetRequest. is just dropping enough? metrics::gauge!("fs.current_handles", "type" => "read").decrement(1.0); handle.finish()?; return Ok(());