Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md generated HTML is being rendered in quoted string on homepage for some reason #714

Open
bluejekyll opened this issue Dec 15, 2024 · 2 comments · May be fixed by #716
Open

README.md generated HTML is being rendered in quoted string on homepage for some reason #714

bluejekyll opened this issue Dec 15, 2024 · 2 comments · May be fixed by #716

Comments

@bluejekyll
Copy link

bluejekyll commented Dec 15, 2024 •
edited
Loading

I updated to oranda 0.6.5 to add to an existing Oranda site: https://hickory-dns.org. The README.md is part of a git submodule. The site config is pretty basic:

{
    "styles": {
      "theme": "hacker",
      "favicon": "static/favicon.ico",
          "logo": "static/logo.png"
    },
    "project": {
      "name": "Hickory DNS",
      "readme_path": "hickory-dns/README.md",
      "repository": "https://github.com/hickory-dns/hickory-dns",
      "license": "MIT OR Apache-2.0"
    }
  }

https://github.com/hickory-dns/hickory-dns.github.io/blob/main/oranda.json

After the update, this got produced in the body, when served locally, you can that the body of the README.md is escaped on inclusion in the primary home page document:

...
          </header>

    &lt;p&gt;&lt;a href=&quot;https:&#x2f;&#x2f;www.whatrustisit.com&quot; rel=&quot;noopener noreferrer&quot;&gt;&lt;img src=&quot;https:&#x2f;&#x2f;img.shields.io&#x2f;badge&#x2f;minimum%20rustc-1.70-green?logo=rust&quot; alt=&quot;minimum rustc: 1.70&quot;&gt;&lt;&#x2f;a&gt;
...

Is there something that I need to change?
@bluejekyll bluejekyll mentioned this issue Dec 15, 2024
Open
@bluejekyll
Copy link
Author

I tried rebuilding back to version 0.5.0 with the same result.

@bluejekyll
Copy link
Author

Ok it looks like the minijinja templating engine is escaping the HTML from the markdown processor. I'll post a PR.

@bluejekyll bluejekyll linked a pull request Dec 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mark output from Markdown as safe to minijinja context bluejekyll/oranda
1 participant
@bluejekyll