Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broadcast_text and _locale tables mixed up for ID 24993,25261,33657 #21233

Open
biosfree opened this issue Jan 22, 2025 · 3 comments
Open

broadcast_text and _locale tables mixed up for ID 24993,25261,33657 #21233

biosfree opened this issue Jan 22, 2025 · 3 comments

Comments

@biosfree
Copy link

Current Behaviour

In the acore_world database in the broadcast_text and broadcast_text_locale tables, the text from broadcast_text does not match the text from locale (when comparing IDs). The following IDs are mixed up: 24993,25261,33657

Expected Blizzlike Behaviour

I don't understand how to check in the game (or according to www.wowhead.com/wotlk data), because I don't understand what the ID from the broadcast_text table correlates to. Accordingly, I cannot understand whether the error is in the broadcast_text or broadcast_text_locale table.

Source

No response

Steps to reproduce the problem

You can see the mismatch by executing an SQL query:

SELECT broadcast_text.ID, broadcast_text.MaleText, broadcast_text.FemaleText, broadcast_text_locale.MaleText, broadcast_text_locale.FemaleText
FROM acore_world.broadcast_text JOIN acore_world.broadcast_text_locale USING (ID)
WHERE ID IN (24993,25261,33657);

Extra Notes

No response

AC rev. hash/commit

d851f97 2025-01-21 20:13:22 -0300 (master branch)

Operating system

Debian 12 x64

Custom changes or Modules

| +- mod-ah-bot
| +- mod-anticheat
| +- mod-eluna
| +- mod-gain-honor-guard
| +- mod-reagent-bank-account
| +- mod-skip-dk-starting-area
| +- mod-solo-lfg
| +- mod-solocraft
| +- mod-starter-guild
| +- mod-transmog

@TheSCREWEDSoftware
Copy link
Contributor

TheSCREWEDSoftware commented Jan 22, 2025

I'm trying to understand the issue here i'm confused. I added broadcast_text_locale.locale to the query to I could visualise the 2 tables with their respectives locales.

SELECT broadcast_text.ID, broadcast_text.MaleText, broadcast_text.FemaleText, broadcast_text_locale.locale, broadcast_text_locale.MaleText, broadcast_text_locale.FemaleText
FROM acore_world.broadcast_text JOIN acore_world.broadcast_text_locale USING (ID)
WHERE ID IN (24993,25261,33657);

Image

Edit: I think i understand what you mean some of this entries are the wrong equivalent translation is that it?

@biosfree
Copy link
Author

The locale text for ID 25261 is in the locale text of ID 24993, and the locale text for ID 24993 corresponds to the locale text for ID 15190.
Even without knowing the languages, this is clearly visible when combining tables.

Provided that we trust the data from the broadcast_text table, we make corrections to the broadcast_text_locale table. These are:

DELETE FROM `broadcast_text_locale` WHERE  `ID` IN (24993, 25261);
INSERT INTO `broadcast_text_locale` (`ID`, `locale`, `MaleText`, `FemaleText`, `VerifiedBuild`) VALUES
	(24993, 'deDE', 'Verschwenden wir keine Zeit!', '', 0),
	(24993, 'esES', '¡No hay tiempo que perder!', '', 0),
	(24993, 'esMX', '¡No hay tiempo que perder!', '', 0),
	(24993, 'frFR', 'Il n\'y a pas de temps à perdre !', '', 0),
	(24993, 'koKR', '시간이 없습니다!', '', 0),
	(24993, 'ruRU', 'Не будем терять времени!', '', 0),
	(24993, 'zhCN', '没时间可以浪费了!', '', 0),
	(24993, 'zhTW', '沒有時間了!', '', 0),
	(25261, 'deDE', 'Madrigosa hat ein besseres Schicksal verdient. Ihr habt getan, was getan werden musste - doch diese Schlacht ist noch lange nicht vorbei!', '', 0),
	(25261, 'esES', 'Madrigosa merecía un destino mejor. Hicisteis lo que teníais que hacer, pero esta batalla aún no ha acabado.', '', 0),
	(25261, 'esMX', 'Madrigosa merecía un destino mejor. Hicisteis lo que teníais que hacer, pero esta batalla aún no ha acabado.', '', 0),
	(25261, 'frFR', 'Madrigosa méritait un sort plus clément. Vous avez fait ce qu\'il fallait, mais cette bataille est loin d\'être terminée !', '', 0),
	(25261, 'koKR', '운명은 마드리고사에게 너무 가혹했습니다. 해야 할 일을 하셨지만, 이 전투가 끝나려면 멀었습니다!', '', 0),
	(25261, 'ruRU', 'Мадригоса не заслужила такой участи... Вы сделали то, что должны были сделать... но эта битва еще не окончена!', '', 0),
	(25261, 'zhCN', '虽然玛蒂苟萨的命运不该如此悲惨,你们的所作所为仍然是必须和必要的,不过,这场战争远未结束!', '', 0),
	(25261, 'zhTW', '瑪卓苟莎的命運不該如此悲慘。但你們只盡了自己的本分,而這場戰爭尚未結束!', '', 0);

Important

But maybe the error is in the broadcast_text table! And then we need to check it somehow first, but I don't understand how to find out what the ID of the broadcast_text table in the game corresponds to?

@biosfree
Copy link
Author

biosfree commented Jan 23, 2025

I found how it correlates: the broadcast_text.ID in the broadcast_text table is the creature_text.BroadcastTextId from the creature_text table.
This means that:

  • the broadcast_text_locale table is correct.
  • the broadcast_text table for ID 24993 and ID 25261 is incorrect.

I will conduct a more thorough audit for possible errors that I still see in the game but did not understand how to investigate them.

P.S.
I would also greatly help those who can clearly explain: - Is the server using the creature_text_locale table?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants