Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need support for primary_connection_string as output from SignalR #993

Open
brianfedorcrowe opened this issue Mar 9, 2022 · 3 comments
Open
Assignees

Comments

@brianfedorcrowe
Copy link

The current implementation of SignalR in CAF Terraform does not support an output of the SignalR primary_connection_string. Some may need this for various reasons, but in our case, we intend to use it for dynamically populating a corresponding key vault secret as part of running terraform apply. This is shown in the attributes list within the Terraform documentation. Perhaps it would be worthwhile to support primary/secondard access keys and connection strings, similar to how it is handled for Cosmos DB. Could you please ensure at least that the SignalR primary_connection_string can be set as output?

@SergioMiyama
Copy link
Contributor

Hi @brianfedorcrowe,
That would be a really great opportunity to contribute, we would really appreciate if you could do so.
Let me know if you can do so I can prioritize the review. If not we will add it to the backlog.

https://github.com/aztfmod/terraform-azurerm-caf/blob/5a0627ea5029e212f1fe798ed7ff8615b61e96af/modules/messaging/signalr_service/output.tf

@SergioMiyama SergioMiyama self-assigned this Mar 10, 2022
@brianfedorcrowe
Copy link
Author

@SergioMiyama - I would be interested in contributing. Can you please provide some guidance for how I can get started?

@brianfedorcrowe
Copy link
Author

Our organization is not yet in a position to contribute to public repos in GitHub. Otherwise we would propose a solution via a PR for this. This issue is preventing us from being able to use the CAF Terraform module for Cosmos DB at this time. However, we're still interested in having this value included in the module output, as I expect others will, too, in order to have a way to have their apps use SignalR by having access to its connection string within Terraform so it can be added to a key vault secret.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants