Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on DFS scan violation discovery, return better options #204

Open
michbarsinai opened this issue Mar 9, 2023 · 2 comments · May be fixed by #219
Open

on DFS scan violation discovery, return better options #204

michbarsinai opened this issue Mar 9, 2023 · 2 comments · May be fixed by #219
Assignees
@maor226
Milestone
PVG-1

Comments

@michbarsinai
Copy link
Member

michbarsinai commented Mar 9, 2023 •
edited
Loading

The DfsBProgramVerifier.ProgressListener::violationFound violation listener should:

  1. Accept a set of violations, not just one.
  2. Return one of the following:
  • CONTINUE
  • PRUNE
  • HALT

Effect of the return values:

  • CONTINUE - mark current node as having a violation, go deeper into the graph.
  • PRUNE - mark current node as having a violation, pop it (as in - go back and don't DFS into its descendants)
  • HALT - mark current node as having a violation and stop the verification.
@michbarsinai michbarsinai added this to the PVG-1 milestone Mar 9, 2023
@maor226 maor226 linked a pull request Sep 4, 2023 that will close this issue
204 on dfs scan violation discovery return better options #219
Open
@achiyae
Copy link
Member

achiyae commented Sep 23, 2023

I want different behaviors (Continue, prone, halt) for different violations. Will it be supported?

@michbarsinai
Copy link
Member Author

Yes, your progress listener will get the violation can can then decide what to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maor226 maor226

Labels
None yet
Projects
None yet
Milestone
PVG-1
Development

Successfully merging a pull request may close this issue.

204 on dfs scan violation discovery return better options bThink-BGU/BPjs
3 participants
@michbarsinai @achiyae @maor226