-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No Stochastic Bald string mapping? #210
Comments
Oh good point! If you could make the PR that would be great, otherwise I'll have time over the weekend |
Can get to this on Wednesday evening I reckon |
What's the best API design for this? Should heuristics remain completely separate to strategies? Should the API operate at the strategy level, which is then a combination of a heuristic and a sampling technique from that? Aim of the PR is to cleanly / consistently / simply expose GibbsSampling, PowerSampling and RankBasedSampling to the user. Should that be exposed as gibbs_bald, power_bald and rank_based_bald in init.py ?
EDIT: I suspect the above is v. much pseudocode. I just mean in terms of the end user experience, is this roughly what we're after? |
Hmm good question. I think for now we can keep Heuristic and Strategy together. So yes something like "power_bald", "power_entropy" would make sense to me. |
https://github.com/ElementAI/baal/blob/d2a31ff5f22b0279b2374e957d92039dbbd34e88/baal/active/__init__.py#L32
The text was updated successfully, but these errors were encountered: