Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies please #13

Closed
secondl1ght opened this issue Dec 15, 2023 · 3 comments
Closed

Upgrade dependencies please #13

secondl1ght opened this issue Dec 15, 2023 · 3 comments

Comments

@secondl1ght
Copy link

secondl1ght commented Dec 15, 2023

The latest version of SvelteKit requires Vite v5. I am not sure if svelte-outclick will break with an incorrect peer dependency but it produces warnings in your package manager:

warning "svelte-outclick > @sveltejs/[email protected]" has incorrect peer dependency "vite@^4.0.0".
warning "svelte-outclick > @sveltejs/kit > @sveltejs/[email protected]" has incorrect peer dependency "vite@^4.0.0".
warning "svelte-outclick > @sveltejs/kit > @sveltejs/vite-plugin-svelte > @sveltejs/[email protected]" has incorrect peer dependency "vite@^4.0.0".

Would you be able to update deps to the latest versions please?

@secondl1ght
Copy link
Author

It also causes errors when running svelte-check which I think many people will be using in their integration pipelines:

error "svelte-outclick#@sveltejs/kit#vite@^4.0.0" doesn't satisfy found match of "[email protected]"
error "svelte-outclick#@sveltejs/kit#@sveltejs/vite-plugin-svelte#vite@^4.0.0" doesn't satisfy found match of "[email protected]"
error "svelte-outclick#@sveltejs/vite-plugin-svelte#@sveltejs/vite-plugin-svelte-inspector#vite@^4.0.0" doesn't satisfy found match of "[email protected]"

So currently upgrading to SvelteKit v2 is not possible with svelte-outclick as a dependency.

@secondl1ght secondl1ght changed the title Upgrade dependencies Upgrade dependencies please Dec 15, 2023
@babakfp
Copy link
Owner

babakfp commented Dec 15, 2023

Hi.
Thank you for reporting this 👍.
I'll be working on it right away and release a new version shortly.
Thanks again.

@babakfp
Copy link
Owner

babakfp commented Dec 15, 2023

Fixed in 3.7.0.
Thanks.

@babakfp babakfp closed this as completed Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants