Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings should be saved in the View's config, not in a database table #3

Open
laryn opened this issue Jan 17, 2025 · 2 comments
Open

Comments

@laryn
Copy link
Member

laryn commented Jan 17, 2025

This caused me some head scratching until I realized that any settings changed in this module were being saved in a separate database table, not in the Views configuration. It seems that should be changed and the database table dropped after an upgrade path to convert those settings into config that is saved in the Views config files directly.

Does that sound right to you @stpaultim ?

@laryn
Copy link
Member Author

laryn commented Jan 17, 2025

Hmmm.. maybe relevant:

 * Because we want our views_distinct options available across all handlers, and
 * aren't a handler ourself, we need to store our field options independently.
 * All options on the config form that are NOT in
 * views_handler_field::option_definition() (ours are not) will be filtered out
 * by views_object::unpack_options() when the Views form callback is fired.

@laryn
Copy link
Member Author

laryn commented Jan 17, 2025

Regardless, it should be config!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant