Issue 6806: Improve setting to enable simplified login page, separate… #4986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from unrelaed tabs position.
jenlampton
force-pushed
the
6806-simplified-login-settings
branch
2 times, most recently
from
df95e57 to
8dc6752
Compare
jenlampton
force-pushed
the
6806-simplified-login-settings
branch
from
8dc6752 to
cf46ace
Compare
|
Tugboat has finished building a preview for this pull request! Website: https://pr4986-pq5i1jdyw9hnjx2eeksrdvnywitnzuks.tugboatqa.com/ This preview will automatically expire on the 9th of March, 2025. |
indigoxela
reviewed
Jan 11, 2025
| @@ -282,6 +296,7 @@ function system_themes_admin_form_submit($form, &$form_state) { | |||
| } | |||
|
|
|||
| $config->set('admin_theme', $new_admin_theme); | |||
| $config->set('login_admin_theme', $form_state['values']['login_admin_theme']); | |||
There was a problem hiding this comment.
Only setting the config item's not sufficient here.
It's probably necessary to flush all caches, as other (cached) hooks are relevant for the simplified display.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes backdrop/backdrop-issues#6806