Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slides are squashed on IE11 #103

Closed
DavidRouyer opened this issue Jun 26, 2019 · 3 comments · Fixed by #105
Closed

Slides are squashed on IE11 #103

DavidRouyer opened this issue Jun 26, 2019 · 3 comments · Fixed by #105
Labels
bug Something isn't working

Comments

@DavidRouyer
Copy link
Contributor

Describe the bug
Slides are squashed on IE11.
It's a problem with the width calculation because it's set to 0 on the slides.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://baianat.github.io/hooper/examples.html with IE11

Expected behavior
The carousel should look right.

Screenshots
Capture

Desktop (please complete the following information):

  • OS: Windows
  • Browser Internet Explorer
  • Version 11
@logaretm logaretm added the bug Something isn't working label Jun 26, 2019
@logaretm logaretm mentioned this issue Jun 26, 2019
Merged
logaretm added a commit that referenced this issue Jun 26, 2019
@logaretm
fix #103 (#105)
26dda3e 
* fix: polyfill Math.sign and Object.assign closes #103

* fix: add polyfill in docs
@logaretm
Copy link
Contributor

Thanks for reporting this, this is fixed in 0.2.3.

The docs have IE11 issues due to Vuepress 1.0 not polyfilling properly but hooper should be working fine for IE11 now.

You can test it here:

https://jsfiddle.net/logaretm/wvknhzso/1/

@DavidRouyer
Copy link
Contributor Author

The polyfills added in 26dda3e were removed in 7bd674f

@logaretm
Copy link
Contributor

logaretm commented Jul 3, 2019 •
edited
Loading

@DavidRouyer Thanks for reporting this, fixed in 0.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #103
2 participants
@DavidRouyer @logaretm