Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

security holding package #96

Closed
DanielRuf opened this issue Jun 18, 2019 · 1 comment · Fixed by #97
Closed

security holding package #96

DanielRuf opened this issue Jun 18, 2019 · 1 comment · Fixed by #97
Labels
bug Something isn't working

Comments

@DanielRuf
Copy link

Hi,

it seems you have accidentally added fs but this is not a package on npmjs, fs is an internal NodeJS module.

https://github.com/baianat/hooper/blob/master/package.json#L30

See https://nodejs.org/api/fs.html

You might want to remove it using yarn remove fs.

Same for path (https://nodejs.org/api/fs.html).
@logaretm logaretm added the bug Something isn't working label Jun 18, 2019
@logaretm logaretm mentioned this issue Jun 18, 2019
Merged
logaretm added a commit that referenced this issue Jun 18, 2019
@logaretm
[fix] remove internal node modules (#97)
743f1c7 
* chore: remove node internal modules closes #96

* chore: remove util internal module
@logaretm
Copy link
Contributor

Thanks for catching this! util was also there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] remove internal node modules
2 participants
@DanielRuf @logaretm