Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RadiusGraphWithNans Clarification #4

Open
vsomnath opened this issue Nov 18, 2020 · 1 comment
Open

RadiusGraphWithNans Clarification #4

vsomnath opened this issue Nov 18, 2020 · 1 comment

Comments

@vsomnath
Copy link

Hi,

Thank you for the great codebase here!

na_receiver = torch.any(edge_index[0] == torch.nonzero(nans, as_tuple=False), dim=0)

For my own clarification, shouldn't the line referenced below be:

na_receiver = torch.any(edge_index[1] == torch.nonzero(nans, as_tuple=False), dim=0)

@baldassarreFe
Copy link
Owner

Hi, that sure looks like it should be edge_index[1]. I don't remember exactly what those two lines do, but it wouldn't make much sense to compare the same thing twice.

Well spotted! Would you be so kind to modify that line, check that it works as intended, and submit a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants