Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App audio switch should play or stop its audio network instead of toggling the global audio graph #16

Closed
balintlaczko opened this issue Feb 17, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@balintlaczko
Copy link
Owner

Currently the audio switch on the app ui and the App.audio prop will trigger either graph.start() or graph.stop() where graph is the global audio graph. To implement multiple apps #3 the switch should be repurposed to instead toggle between self.audio_out.play() and self.audio_out.stop() which register or deregister the App's audio network on the graph (instead of starting/stopping the graph itself, which could have bad side-effects).

@balintlaczko balintlaczko added the enhancement New feature or request label Feb 17, 2025
@balintlaczko balintlaczko added this to the Refinement release milestone Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant