Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multi-chord shortcuts to match Emacs #181

Open
nkaretnikov opened this issue Jan 29, 2024 · 1 comment
Open

Use multi-chord shortcuts to match Emacs #181

nkaretnikov opened this issue Jan 29, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@nkaretnikov
Copy link

nkaretnikov commented Jan 29, 2024

I haven't tested this, but based on the README:

Commands working with types (marked with the 🎚 emoji below) can have different levels of normalization. However, due to some technical limitations, we cannot prefix commands with C-u or C-u C-u like in Emacs. Instead, we replace the C-u C-c prefix with C-u and the C-u C-u C-c prefix with C-y.

The technical limitations part refers to the upstream issue in VSCode, which I believe has been implemented: microsoft/vscode#175253.

If so, the default shortcuts need to be changed to match Emacs because that's the current go-to editor for Agda, which many users will be familiar with. Emacs shortcuts are also something you can see often in third-party documentation or tutorials, just because it's the default. By having the same set of shortcuts, it'll make it easier for current Emacs users to transition to this extension.

As an aside, I personally prefer more ergonomic shortcuts, like in Spacemacs, but that can always be configured by the users. This can be also provided in settings, in addition to the default Emacs shortcuts.

I think there's also value in keeping the current shortcuts as is because they are more ergonomic than the default Emacs ones. So this could be a setting in the configuration:

  • emacs (multi-chord)
  • spacemacs (with spc) - this one might be also useful for the Vim extension users, like myself (due to conflicting shortcuts in the current default)
  • vscode (current).
@banacorn banacorn added the enhancement New feature or request label Mar 20, 2024
@banacorn
Copy link
Owner

The technical limitations part refers to the upstream issue in VSCode, which I believe has been implemented: microsoft/vscode#175253.

Great news!

Personally, I would like to use the Emacs shortcuts as the default. But I'm thinking maybe we can also keep both shortcuts (Emacs + current), it's that's not too pollutive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants