You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
If you pass a directory that does not contain a config.yaml to truss push, it will throw a FileNotFoundError, but incorrectly still return a 0 exit code.
To Reproduce
Run truss push on a directory that does not contain a config.yaml
Run echo $? to get the last exit code
Expected behaviour
truss returns a nonzero exit code
Actual behaviour
truss returns a zero exit code
Screenshots/Logs
N/A
Desktop (please complete the following information):
macOS
Truss version 0.9.29
Additional context
GitHub actions uses nonzero exit codes to signal failure for a given stage. We use actions to auto deploy into production using truss - unfortunately the pipeline was silently failing for a few days since we moved the config.yaml but forgot to update the action's yaml.
The text was updated successfully, but these errors were encountered:
Hi @brendan-kellam , sorry for the delay here. We will work on a fix here, thanks for reporting.
One thing to mention since you're using truss push in a CI/CD pipeline -- we have a Python SDK for Truss now: https://docs.baseten.co/truss-reference/python-sdk, which users seem to find more convenient for programmatic use-cases like this.
Describe the bug
If you pass a directory that does not contain a
config.yaml
totruss push
, it will throw aFileNotFoundError
, but incorrectly still return a 0 exit code.To Reproduce
truss push
on a directory that does not contain aconfig.yaml
echo $?
to get the last exit codeExpected behaviour
truss returns a nonzero exit code
Actual behaviour
truss returns a zero exit code
Screenshots/Logs
N/A
Desktop (please complete the following information):
Additional context
GitHub actions uses nonzero exit codes to signal failure for a given stage. We use actions to auto deploy into production using truss - unfortunately the pipeline was silently failing for a few days since we moved the
config.yaml
but forgot to update the action's yaml.The text was updated successfully, but these errors were encountered: